From: Jeff King Date: Fri, 05 Apr 2013 22:22:31 GMT Subject: [PATCH 9/9] http: drop http_error function Message-ID: <20130405222231.GI22163@sigill.intra.peff.net> In-Reply-To: <20130405221331.GA21209@sigill.intra.peff.net> This function is a single-liner and is only called from one place. Just inline it, which makes the code more obvious. Signed-off-by: Jeff King --- This is a cleanup made possible by the previous patch. http-push.c | 2 +- http.c | 5 ----- http.h | 5 ----- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/http-push.c b/http-push.c index 439a555..395a8cf 100644 --- a/http-push.c +++ b/http-push.c @@ -1551,7 +1551,7 @@ static int remote_exists(const char *path) ret = 0; break; case HTTP_ERROR: - http_error(url); + error("unable to access '%s': %s", url, curl_errorstr); default: ret = -1; } diff --git a/http.c b/http.c index 64068a2..58c063c 100644 --- a/http.c +++ b/http.c @@ -941,11 +941,6 @@ cleanup: return ret; } -void http_error(const char *url) -{ - error("unable to access '%s': %s", url, curl_errorstr); -} - int http_fetch_ref(const char *base, struct ref *ref) { char *url; diff --git a/http.h b/http.h index fa65128..4dc5353 100644 --- a/http.h +++ b/http.h @@ -135,11 +135,6 @@ int http_get_strbuf(const char *url, struct strbuf *content_type, struct strbuf */ int http_get_strbuf(const char *url, struct strbuf *content_type, struct strbuf *result, int options); -/* - * Prints an error message using error() containing url and curl_errorstr. - */ -void http_error(const char *url); - extern int http_fetch_ref(const char *base, struct ref *ref); /* Helpers for fetching packs */ -- 1.8.2.rc0.33.gd915649