From: Jeff King <peff@peff.net>
Date: Thu, 04 Apr 2013 17:51:50 GMT
Subject: Re: [PATCH 1/2] diffcore-pickaxe: respect --no-textconv
Message-ID: <20130404175150.GA15630@sigill.intra.peff.net>
In-Reply-To: <7vvc82i40a.fsf@alter.siamese.dyndns.org>

On Thu, Apr 04, 2013 at 10:45:25AM -0700, Junio C Hamano wrote:

> Simon Ruderich <simon@ruderich.org> writes:
> 
> > git log -S doesn't respect --no-textconv:
> >
> >     $ echo '*.txt diff=wrong' > .gitattributes
> >     $ git -c diff.wrong.textconv='xxx' log --no-textconv -Sfoo
> >     error: cannot run xxx: No such file or directory
> >     fatal: unable to read files to diff
> >
> > Reported-by: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
> > Signed-off-by: Simon Ruderich <simon@ruderich.org>
> > ---
> 
> Sounds sensible.
> 
> With this change fill_one() no longer needs to update textconv, it
> can just take a pointer to one, not a pointer to a pointer to one,
> which is [2/2].
> 
> Peff, anything I missed?

I'm OK with this as-is, but I would also be happy to see the re-ordering
and extra cleanup I mentioned elsewhere.

But either way:

  Acked-by: Jeff King <peff@peff.net>

-Peff