From: Jonathan Nieder Date: Thu, 28 Mar 2013 18:57:07 GMT Subject: Re: [PATCH v2] git-send-email.perl: implement suggestions made by perlcritic Message-ID: <20130328185707.GR28148@google.com> In-Reply-To: <1364474835-23416-1-git-send-email-artagnon@gmail.com> Ramkumar Ramachandra wrote: > Junio: In future, please tell me explicitly that you're expecting a > re-roll with an updated commit message. It wasn't obvious to me at > all. When there are questions in response to a patch, there are two possibilities: * temporary brainfart --- sorry for the bother * the clarity of the patch or commit message has room for improvement This wasn't a case of the former, so a seasoned contributor could safely assume that it was definitely a case of the latter. The explanation in Linux kernel's Documentation/SubmittingPatches item 10 ("Don't get discouraged. Re-submit") has some fitting advice. Hope that helps, Jonathan