From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 21 Mar 2013 20:47:09 GMT
Subject: Re: [PATCH 3/4] drop some obsolete "x = x" compiler warning hacks
Message-ID: <20130321204709.GL29311@google.com>
In-Reply-To: <20130321111028.GC18819@sigill.intra.peff.net>

Jeff King wrote:

> And 4.3 was old enough for me to say "I do not care if you can run with
> -Wall -Werror or not", let alone 4.2.

Changes like this can only reveal bugs (in git or optimizers) that
were hidden before, without regressing actual runtime behavior, so for
what it's worth I like them.

I think perhaps we should encourage people to use
-Wno-error=uninitialized, in addition to cleaning up our code where
reasonably recent optimizers reveal it to be confusing.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>