From: Jeff King Date: Wed, 20 Mar 2013 19:13:27 GMT Subject: Re: [PATCH v2] index-pack: always zero-initialize object_entry list Message-ID: <20130320191327.GA31383@sigill.intra.peff.net> In-Reply-To: On Wed, Mar 20, 2013 at 03:12:07PM -0400, Eric Sunshine wrote: > On Tue, Mar 19, 2013 at 12:17 PM, Jeff King wrote: > > To ensure that all depths start at 0, that commit changed > > calls to xmalloc the object_entry list into calls to > > xcalloc. However, it forgot that we grow the list with > > xrealloc later. These extra entries are used when we add an > > object from elsewhere pack to complete a thin pack. If we > > s/elsewhere pack/pack/ I think it is supposed to be s/elsewhere pack/elsewhere/. Thanks for noticing. -Peff