From: Heiko Voigt Date: Wed, 27 Feb 2013 07:56:28 GMT Subject: Re: [PATCH 1/4] config: factor out config file stack management Message-ID: <20130227075627.GB4685@sandbox-ub> In-Reply-To: <7vk3pulo6w.fsf@alter.siamese.dyndns.org> On Tue, Feb 26, 2013 at 02:12:23PM -0800, Junio C Hamano wrote: > Heiko Voigt writes: > > > The "do_config_from" means "parse from whatever is in 'top'". Later in > > the series its type changes from config_file to struct config. > > Yuck. It would be nice to have it as struct config_src or > something. "struct config" sounds as if it represents the entire > configuration state and you can ask it to add new ones or enumerate > all known configuration variables, etc. Will change it to struct config_source. I choose that name in lack of a better one. Since it can be considered the base for both sources I just removed the _file postfix. Cheers Heiko