From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 18 Feb 2013 10:54:41 GMT
Subject: Re: [PATCHv2 06/10] pkt-line: share buffer/descriptor reading implementation
Message-ID: <20130218105440.GI7049@elie.Belkin>
In-Reply-To: <20130218104804.GB16408@sigill.intra.peff.net>

Jeff King wrote:

> But is it noisy about a missing pipe? We do not get EPIPE for reading.

Ah, that makes more sense.

[...]
>>> +		len = packet_read_from_buf(line, sizeof(line), &last->buf, &last->len);
>>> +		if (len && line[len - 1] == '\n')
>>> +			len--;
>>
>> Was anything guaranteeing that buffer.len < 1000 before this change?
>
> No. That's discussed in point (3) of the "implications" in the commit
> message.

Thanks.  Sorry I missed it the first time.