From: Jonathan Nieder Date: Mon, 18 Feb 2013 10:47:18 GMT Subject: Re: [PATCHv2 08/10] remote-curl: pass buffer straight to get_remote_heads Message-ID: <20130218104718.GG7049@elie.Belkin> In-Reply-To: <20130218092905.GH5096@sigill.intra.peff.net> Jeff King wrote: > I don't know that this code was hurting anything, but it has always > struck me as ugly and a possible source of error. And now it's gone. Heh. Belongs in the commit message, presumably. I don't think the async procedure was very harmful, but it's nice to avoid the cost of a new thread and some copying. > remote-curl.c | 26 ++------------------------ > 1 file changed, 2 insertions(+), 24 deletions(-) Nice. The patch looks sane.