From: Matt Kraai <kraai@ftbfs.org>
Date: Fri, 08 Feb 2013 04:39:16 GMT
Subject: Re: [PATCH] Use __VA_ARGS__ for all of error's arguments
Message-ID: <20130208043915.GB4525@ftbfs.org>
In-Reply-To: <20130208042428.GA4157@sigill.intra.peff.net>

On Thu, Feb 07, 2013 at 11:24:28PM -0500, Jeff King wrote:
> Should you be dropping most of the comment like this? I would expect it
> to be more like:
> 
>   We have to restrict this trick to gcc, though, because we do not
>   assume all compilers support variadic macros. But since...

I'll submit a new patch with this change tomorrow.

> Other than that, I think it is OK. The compiler will still catch
> "error()" with no arguments and generate the appropriate diagnostic (in
> fact, it is better, because the error is now passing too few args to a
> function, not to the macro).

Great, thanks for the review.

-- 
Matt