From: Matt Kraai <kraai@ftbfs.org>
Date: Thu, 07 Feb 2013 21:24:38 GMT
Subject: Re: [PATCH] Use __VA_ARGS__ for all of error's arguments
Message-ID: <20130207212438.GA22253@ftbfs.org>
In-Reply-To: <7vwquj6dio.fsf@alter.siamese.dyndns.org>

On Thu, Feb 07, 2013 at 01:05:19PM -0800, Junio C Hamano wrote:
> Matt Kraai <kraai@ftbfs.org> writes:
> 
> > -#if defined(__GNUC__) && ! defined(__clang__)
> > -#define error(fmt, ...) (error((fmt), ##__VA_ARGS__), -1)
> > -#endif
> > +#define error(...) (error(__VA_ARGS__), -1)
> 
> Before your change, we only define error() macro for GCC variants,
> but with your patch that no longer is the case.  Does every compiler
> that compiles Git correctly today support this style of varargs
> macros?

I don't know and I don't think it's likely I can confirm this.  I'll
submit a new patch that just changes the definition, since I don't
know of any problems other than mine with the current situation.

-- 
Matt