From: Jeff King <peff@peff.net>
Date: Thu, 31 Jan 2013 22:37:10 GMT
Subject: Re: [PATCHv2 1/3] gpg: Close stderr once finished with it in verify_signed_buffer()
Message-ID: <20130131223710.GD21729@sigill.intra.peff.net>
In-Reply-To: <1359656320-4434-1-git-send-email-sboyd@codeaurora.org>

On Thu, Jan 31, 2013 at 10:18:40AM -0800, Stephen Boyd wrote:

> Failing to close the stderr pipe in verify_signed_buffer() causes
> git to run out of file descriptors if there are many calls to
> verify_signed_buffer(). An easy way to trigger this is to run
> 
>  git log --show-signature --merges | grep "key"
> 
> on the linux kernel git repo. Eventually it will fail with
> 
>  error: cannot create pipe for gpg: Too many open files
>  error: could not run gpg.
> 
> Close the stderr pipe so that this can't happen.
> 
> Suggested-by: Jeff King <peff@peff.net>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

Thanks, looks good to me (obviously :) ). The rest of the series looks
fine, too, with the caveat I mentioned on 2/3. Thanks for fixing this.

-Peff