From: Jonathan Nieder Date: Mon, 28 Jan 2013 03:08:58 GMT Subject: Re: [PATCH v3 07/11] sequencer.c: teach append_signoff how to detect duplicate s-o-b Message-ID: <20130128030858.GJ8206@elie.Belkin> In-Reply-To: <1359335515-13818-8-git-send-email-drafnel@gmail.com> Brandon Casey wrote: > Teach append_signoff how to detect a duplicate s-o-b in the commit footer. This replaces the previous (slightly broken) logic that checked whether the sign-off to be appended would be redundant and puts the fixed logic further down the call-chain next to the rest of footer parsing. I am not thrilled with the 0 = no rfc-style footer 1 = rfc-style footer, no sign-off found 2 = rfc-style footer, sign-off found but not as last field 3 = rfc-style footer, sign-off found as last field convention but since it's local to sequencer.c and this logic to scan all lines for the sign-off can probably be ripped out soon I don't mind. The general direction is good and the execution looks obviously correct. Reviewed-by: Jonathan Nieder