From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sun, 27 Jan 2013 23:40:14 GMT
Subject: Re: [PATCH v2 03/10] t/t3511: add some tests of 'cherry-pick -s' functionality
Message-ID: <20130127234014.GB8206@elie.Belkin>
In-Reply-To: <CA+sFfMc0_QxwtJ6YS6H+GOW+Pzh3tSZs3rW-VSDf-GWeL=3tDA@mail.gmail.com>

Brandon Casey wrote:

>                                                            I'll tweak
> the string so it looks like this:
>
> The signed-off-by string should begin with the words Signed-off-by followed
> by a colon and space, and then the signers name and email address. e.g.
> Signed-off-by: $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>

Yep, that looks better than the example I suggested. :)

[...]
> On Tue, Jan 22, 2013 at 12:17 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:

>> One more test would be interesting: what does "-s" do when asked to
>> produce a duplicate signoff with an interspersed signoff by someone else?
[...]
> This one exists as "adds sob when last sob doesn't match committer".

So it does.  Thanks for the sanity check.