From: John Keeping Date: Sat, 26 Jan 2013 23:32:42 GMT Subject: [PATCH] git-remote-testpy: fix patch hashing on Python 3 Message-ID: <20130126233242.GM7498@serenity.lan> In-Reply-To: <7vwquzzkiw.fsf@alter.siamese.dyndns.org> When this change was originally made (0846b0c - git-remote-testpy: hash bytes explicitly , I didn't realised that the "hex" encoding we chose is a "bytes to bytes" encoding so it just fails with an error on Python 3 in the same way as the original code. Since we want to convert a Unicode string to bytes, UTF-8 really is the best option here. Signed-off-by: John Keeping --- On Sat, Jan 26, 2013 at 01:44:55PM -0800, Junio C Hamano wrote: > Ahh. I think it is already in "next", so this needs to be turned > into an incremental to flip 'hex' to 'utf-8', with the justification > being these five lines above. Here it is, based on next obviously. git-remote-testpy.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-remote-testpy.py b/git-remote-testpy.py index c7a04ec..4713363 100644 --- a/git-remote-testpy.py +++ b/git-remote-testpy.py @@ -45,7 +45,7 @@ def get_repo(alias, url): repo.get_head() hasher = _digest() - hasher.update(repo.path.encode('hex')) + hasher.update(repo.path.encode('utf-8')) repo.hash = hasher.hexdigest() repo.get_base_path = lambda base: os.path.join( -- 1.8.1.1