From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 14 Jan 2013 06:47:59 GMT
Subject: Re: [PATCH 11/14] imap-send.c: simplify logic in lf_to_crlf()
Message-ID: <20130114064759.GI3125@elie.Belkin>
In-Reply-To: <1358141566-26081-12-git-send-email-mhagger@alum.mit.edu>

Michael Haggerty wrote:

> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---
>  imap-send.c | 31 ++++++++-----------------------
>  1 file changed, 8 insertions(+), 23 deletions(-)

I like the code reduction, but my nighttime brain doesn't have the
patience to understand the preimage or postimage, and the above
description doesn't give any hints.  Maybe a comment right above the
function definition describing its contract would help to prepare the
daunted reader (and to let the uninterested understand call sites
without reading the implementation).

Thanks,
Jonathan