From: Jeff King Date: Sun, 06 Jan 2013 14:33:20 GMT Subject: Re: [PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named "f*" Message-ID: <20130106143319.GA10690@sigill.intra.peff.net> In-Reply-To: <50E9852F.2060005@kdbg.org> On Sun, Jan 06, 2013 at 03:07:43PM +0100, Johannes Sixt wrote: > Windows disallows file names that contain a star. Arrange the test setup > to insert the file name "f*" in the repository without the corresponding > file in the worktree. > [...] > - test_commit star "f*" && > + # insert file "f*" in the commit, but in a way that avoids > + # the name "f*" in the worktree, because it is not allowed > + # on Windows (the tests below do not depend on the presence > + # of the file in the worktree) > + git update-index --add --cacheinfo 100644 "$(git rev-parse HEAD:foo)" "f*" && > + test_tick && > + git commit -m star && Thanks, looks obviously correct to me. Sorry to break Windows again. It seems I learn about a new gotcha with every patch series. :) -Peff