From: Matt Kraai <kraai@ftbfs.org>
Date: Sat, 05 Jan 2013 10:39:00 GMT
Subject: Re: [PATCH] Add getenv.so for catching invalid getenv() use via LD_PRELOAD
Message-ID: <20130105103900.GA4200@ftbfs.org>
In-Reply-To: <1357376146-7155-1-git-send-email-pclouds@gmail.com>

On Sat, Jan 05, 2013 at 03:55:46PM +0700, Nguyễn Thái Ngọc Duy wrote:
>  Perhaps this will help the getenv bug hunting (I assume we do the
>  hunting on Linux platform only). So far it catches this and is stuck
>  at getenv in git_pager().

It seems like a static analysis tool might be able to detect these
problems.  Is there a way to do so using sparse?

> +		n = backtrace(buffer, 100);
> +		symbols = backtrace_symbols(buffer, n);
> +		if (symbols) {
> +			for (i = 0;i < n; i++)

s/;i/; i/

-- 
Matt Kraai
https://ftbfs.org/kraai