From: Jeff King <peff@peff.net>
Date: Fri, 21 Dec 2012 17:09:27 GMT
Subject: Re: [PATCH] http.c: Avoid username prompt for certifcate credentials
Message-ID: <20121221170927.GA23574@sigill.intra.peff.net>
In-Reply-To: <1356107479-6668-1-git-send-email-git@unrelated.de>

On Fri, Dec 21, 2012 at 05:31:19PM +0100, Rene Bredlau wrote:

> If sslCertPasswordProtected is set to true do not ask for username to
> decrypt rsa key. This question is pointless, the key is only protected
> by a password. Internaly the username is simply set to "".

Yeah, that makes sense. I suspect the cert-unlocking code paths for
credential helpers are not that well used (and I do not think we have
any test coverage for them at all), so I am not too surprised that this
went unreported for a long time.

Thanks.

> Signed-off-by: Rene Bredlau <git@unrelated.de>

Acked-by: Jeff King <peff@peff.net>

-Peff