From: W. Trevor King <wking@tremily.us>
Date: Wed, 12 Dec 2012 22:44:25 GMT
Subject: Re: [PATCH v7 0/3] submodule update: add --remote for submodule's upstream changes
Message-ID: <20121212224425.GA7729@odin.tremily.us>
In-Reply-To: <7vzk1j3zgr.fsf@alter.siamese.dyndns.org>

On Wed, Dec 12, 2012 at 10:19:32AM -0800, Junio C Hamano wrote:
> In any case, I ended up applying them by editing the patches, and I
> should have a good copy in 'pu'.  Please double check the result.

Your 'pu' branch looks good to me.  Most of the differences with my
initial patch are due to irrelevant context lines.  I would change
patch 3 (commit 2f507f9a in 'pu') to use

  git config -f .gitmodules submodule."$sm_name".branch "$branch"
                                           ^
instead of

  git config -f .gitmodules submodule."$sm_path".branch "$branch"
                                           ^
to match the nearby changes from 73b0898d.

Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy