From: Jeff King Date: Sat, 01 Dec 2012 17:39:43 GMT Subject: Re: [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate Message-ID: <20121201173943.GA18339@sigill.intra.peff.net> In-Reply-To: On Sat, Dec 01, 2012 at 01:31:23PM +0100, Erik Faye-Lund wrote: > >> One thing you might want to mention is that the fgetc() handling is not > >> thread-safe, and intentionally so: if two threads read from the same > >> console, we are in trouble anyway. > > > > That makes sense to me, but I'm confused why it is part of mingw_fgetc, > > which could in theory read from arbitrary streams, no? It it is not > > necessarily a console operation at all. I feel like I'm probably missing > > something subtle here... > > I did add an early out for the non-console cases. Is this what you're > missing, perhaps? Oops, yes. That is exactly what I was missing. :) Sorry for the noise. -Peff -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en