From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sat, 17 Nov 2012 23:40:59 GMT
Subject: Re: [PATCH 4/7] completion: add tests for invalid variable name among completion words
Message-ID: <20121117234059.GD3815@elie.Belkin>
In-Reply-To: <1353150353-29874-5-git-send-email-szeder@ira.uka.de>

SZEDER Gábor wrote:

>                                                      The breakage can
> be simply bogus possible completion words, but it can also be a
> failure:
>
>   $ git branch '${foo.bar}'
>   $ git checkout <TAB>
>   bash: ${foo.bar}: bad substitution

Or arbitrary code execution:

	$ git branch '$(>kilroy-was-here)'
	$ git checkout <TAB>
	$ ls -l kilroy-was-here
	-rw-rw-r-- 1 jrn jrn 0 nov 17 15:40 kilroy-was-here

The final version of this patch should go to maint.  Thanks for
catching it.