From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 15 Nov 2012 07:46:58 GMT
Subject: Re: [PATCHv2 1/8] test-lib: allow negation of prerequisites
Message-ID: <20121115074658.GA8429@elie.Belkin>
In-Reply-To: <20121115003325.GA17819@sigill.intra.peff.net>

Jeff King wrote:

> +test_expect_success !LAZY_TRUE 'missing lazy prereqs skip tests' '

I have a visceral nervousness when reading this code, from too much
unpleasant experience of bash's csh-style !history expansion.  Luckily
bash does not treat ! specially in the '-o sh' mode used by tests.

Does this feature work when running a test explicitly using
"bash <name of test>"?  That's something I do from time to time to
figure out whether a weird behavior is shell-specific.

If it works everywhere, this patch would help me conquer my fear of
exclamation points in git's tests, which would be a comfort to me and
a very good thing.