From: Jeff King Date: Tue, 13 Nov 2012 03:27:27 GMT Subject: Re: [PATCH] send-email: add proper default sender Message-ID: <20121113032727.GA8387@sigill.intra.peff.net> In-Reply-To: On Tue, Nov 13, 2012 at 01:54:59AM +0100, Felipe Contreras wrote: > > But we use the environment to default the field, so the distinction > > doesn't make much sense to me. Plus, it has always been the case that > > you can use git without setting user.*, but instead only using the > > environment. I don't see any reason not to follow that principle here, > > too. > > And that's why a lot of commits end up like michael > . No, it's not. Those broken names do not come from the environment, but from our last-resort guess of the hostname. We long ago switched to printing the name as a warning when we have made such a guess (bb1ae3f), then more recently started rejecting them outright (8c5b1ae). And I have proposed exactly the same behavior here: respect the environment and the config, but do not trust the implicit guesses. > Probably. But what I really want is to stop 'git send-email' from > asking. I think the one next step further can be done later. But in the meantime you are causing a regression for anybody who expects GIT_AUTHOR_NAME to override user.email when running git-send-email (and you have taken away the prompt that they could have used to notice and correct it). -Peff