From: Jeff King <peff@peff.net>
Date: Thu, 08 Nov 2012 16:56:48 GMT
Subject: Re: [PATCH] gitweb: make remote_heads config setting work.
Message-ID: <20121108165648.GG15560@sigill.intra.peff.net>
In-Reply-To: <20121105235047.GA78156@redoubt.spodhuis.org>

On Mon, Nov 05, 2012 at 06:50:47PM -0500, Phil Pennock wrote:

> Git configuration items can not contain underscores in their name; the
> 'remote_heads' feature can not be enabled on a per-repository basis with
> that name.
> 
> This changes the git-config option to be `gitweb.remoteheads` but does
> not change the gitweb.conf option, to avoid backwards compatibility
> issues.  We strip underscores from keys before looking through
> git-config output for them.

Makes sense. Thanks for considering the backwards compatibility angle.
Hopefully we can avoid adding names with underscores in the future, but I
think the mapping of "remote_head -> remotehead" is obvious enough that
we do not need to worry about deprecating and replacing the old name.

-Peff