From: Matt Kraai <kraai@ftbfs.org>
Date: Wed, 31 Oct 2012 15:48:07 GMT
Subject: Re: [PATCH] parse_dirstat_params(): use string_list to split comma-separated string
Message-ID: <20121031154807.GA19483@ftbfs.org>
In-Reply-To: <20121031140636.GA24291@sigill.intra.peff.net>

On Wed, Oct 31, 2012 at 10:06:36AM -0400, Jeff King wrote:
> On Tue, Oct 30, 2012 at 06:43:51PM +0000, Matt Kraai wrote:
> 
> > Michael Haggerty <mhagger <at> alum.mit.edu> writes:
> > > +	if (*params_copy)
> > 
> > params_copy is set to the value returned by xstrdup, which cannot be NULL.
> > This check can be removed and if params_string can be NULL, it should be
> > checked before being passed to xstrdup.
> 
> If you are referring to the last line, isn't it checking whether the
> string is empty, not NULL?

Oops, you're right.  Sorry for misreading that.

-- 
Matt Kraai
https://ftbfs.org/kraai