From: SZEDER Gábor Date: Tue, 30 Oct 2012 22:58:39 GMT Subject: Re: [PATCH v6 2/3] completion: add new __gitcompadd helper Message-ID: <20121030225839.GO12052@goldbirke> In-Reply-To: <1350870342-22653-3-git-send-email-felipe.contreras@gmail.com> On Mon, Oct 22, 2012 at 03:45:41AM +0200, Felipe Contreras wrote: > The idea is to never touch the COMPREPLY variable directly. > > This allows other completion systems override __gitcompadd, and do > something different instead. > > Also, this allows the simplification of the completion tests (separate > patch). This doesn't apply anymore, does it? The mentioned simplification is done in the other series.