From: Jeff King <peff@peff.net>
Date: Mon, 29 Oct 2012 11:43:10 GMT
Subject: Re: [PATCH v2] git-submodule add: Add -r/--record option.
Message-ID: <20121029114310.GA16046@sigill.intra.peff.net>
In-Reply-To: <20121029112945.GD2424@odin.tremily.us>

On Mon, Oct 29, 2012 at 07:29:45AM -0400, W. Trevor King wrote:

> On Mon, Oct 29, 2012 at 06:58:55AM -0400, Jeff King wrote:
> > Can you send an updated version of the patch that summarizes the
> > situation in the commit message?
> 
> Sure.  Should I include Phil's $submodule_<var-name> export, or would
> you rather have that be a separate series?

I think it probably makes sense as a separate patch in the same series,
since it is meant to support the same workflows.

I am not sure it is sufficient as-is, though. It does not seem to ever
clear variables, only set them, which means that values could leak
across iterations of the loop, or down to recursive calls. E.g., when
the first submodule has submodule.*.foo set but the second one does not,
you will still end up with $submodule_foo set when you process the
second one.

-Peff