From: Jeff King <peff@peff.net>
Date: Thu, 18 Oct 2012 07:54:29 GMT
Subject: Re: [PATCH 2/2] filter-branch: use git-sh-setup's ident parsing functions
Message-ID: <20121018075429.GD9999@sigill.intra.peff.net>
In-Reply-To: <507FB470.2060404@viscovery.net>

On Thu, Oct 18, 2012 at 09:49:04AM +0200, Johannes Sixt wrote:

> > -			s/.*/GIT_'$uid'_NAME='\''&'\''; export GIT_'$uid'_NAME/p
> 
> Didn't you lose the export GIT_$uid_{NAME,EMAIL,DATE} parts somewhere on
> the way?

Yikes, you're right. I didn't even notice, as the test suite still
passes. I can see how the env filter would still be able to see the
variables, but the commit-tree call wouldn't. I guess it happens to work
because we do not test alternate idents in our filter branch tests (IOW,
we are silently rewriting each commit during the filter-branch, but it
happens to have the same identities).

I'll investigate.

-Peff