From: Michal Kiedrowicz Date: Thu, 04 Oct 2012 06:05:43 GMT Subject: Re: grep.patternType Message-ID: <20121004080543.3b31280f@mkiedrowicz> In-Reply-To: <7vmx032of1.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > Junio C Hamano writes: > > > Junio C Hamano writes: > > > >> * "git grep" learned to use a non-standard pattern type by > >> default if a configuration variable tells it to. > > > > This addition makes > > > > git grep -e "(integer|buffer)" > > > > work as expected, when grep.patternType is set to "extended". > > > > Should this > > > > git log --grep="(integer|buffer)" > > > > also honor the same configuration variable? If not, why not? I think this should respect grep.patternType. > > > > One more thing. Currently you can say > > > > git log -E --grep="(integer|buffer)" > > > > to ask for the ERE. Should we also support -P to ask for pcre? If > > not, why not? This also. > > Answering to myself who has been in tying-loose-ends mode. > > My answers to these questions are both yes, and I have a neatly > lined up series that begins with a small bugfix and then > enhancement, but I do not think these do not deserve to in the > upcoming release. The topic came too late, and even the fix is > for a bug that has been with us for a long time. I think I am the one to blame for this inconsistency. When I implemented "git-grep -P" I was thinking about making it work for all regex operations in git but since I'm mostly using regexes with git-grep I was too lazy to make it work with git-log.