From: SZEDER Gábor <szeder@ira.uka.de>
Date: Wed, 26 Sep 2012 01:26:33 GMT
Subject: Re: Problem completing remotes when .git/remotes exits
Message-ID: <20120926012633.GE10144@goldbirke>
In-Reply-To: <20120926010938.GD10144@goldbirke>

On Wed, Sep 26, 2012 at 03:09:38AM +0200, SZEDER Gábor wrote:
> On Wed, Sep 26, 2012 at 01:00:45AM +0200, SZEDER Gábor wrote:
> > But then it got me thinking...  Notice how much effort we spend just
> > to get the list of remotes?  We could just run 'git remote' directly
> > instead...
> 
> Actually, we can't, because 'git remote' doesn't seem to list remotes
> stored under .git/remotes.  Is that intentional?

Looks like a bug, as it seems to have been lost in translation in
211c8968 (Make git-remote a builtin, 2008-02-29).

list_remote() in git-remote.perl looks for remotes in config and in
.git/remotes/, too.  The builtin implementation uses
remote.c:for_each_remote() from the start, which only looks at the
config.