From: Jeff King <peff@peff.net>
Date: Fri, 21 Sep 2012 20:58:34 GMT
Subject: Re: [PATCH] t/test-lib.sh: do not trust $SHELL
Message-ID: <20120921205834.GC22977@sigill.intra.peff.net>
In-Reply-To: <1348260766-25287-1-git-send-email-artagnon@gmail.com>

On Sat, Sep 22, 2012 at 02:22:46AM +0530, Ramkumar Ramachandra wrote:

> Replace $SHELL with an explicit `/bin/sh`, as some shells do not
> support all the features used in the script.  For example, ZSH does
> not respect IFS, which is used in line 478.

I don't think that is the right thing to do. The point of SHELL is to
point at a bourne-compatible shell. On some systems, the main reason to
set it is that /bin/sh is _broken_, and we are trying to avoid it.

A bigger question is: why are you setting SHELL=zsh in the first place?

-Peff