From: Adam Spiers Date: Wed, 19 Sep 2012 20:12:01 GMT Subject: Re: [PATCH] Make test output coloring more intuitive Message-ID: <20120919201201.GD19246@atlantic.linksys.moosehall> In-Reply-To: <505A24EC.1000203@gmail.com> On Wed, Sep 19, 2012 at 10:02:52PM +0200, Stefano Lattarini wrote: > On 09/17/2012 10:11 PM, Jeff King wrote: > > On Mon, Sep 17, 2012 at 12:50:37PM +0100, Adam Spiers wrote: > > > >> The end result of these changes is that: > >> > >> - red is _only_ used for things which have gone unexpectedly wrong: > >> test failures, unexpected test passes, and failures with the > >> framework, > >> > >> - yellow is _only_ used for known breakages, and > >> > >> - green is _only_ used for things which have gone to plan and > >> require no further work to be done. > > > > Sounds reasonable, and I think the new output looks nice. I notice that > > skipped tests are still in green. I wonder if they should be in yellow, > > too. > > > What about blue instead? This would keep the colouring scheme more > consistent with the one used by prove: > > by autotest: > > and by the Automake-generated test harness: > Sounds good to me! Blue is the conventional color for informational signs, so seems like a natural fit for skipped tests. Not sure whether it should be bold or not though? I'll wait for a more solid group consensus before re-rolling yet another patch :-)