From: Jeff King <peff@peff.net>
Date: Wed, 19 Sep 2012 17:50:36 GMT
Subject: Re: [PATCH v2 2/6] Make 'not ok $count - $message' consistent with 'ok $count - $message'
Message-ID: <20120919175036.GB11699@sigill.intra.peff.net>
In-Reply-To: <1348074915-19985-3-git-send-email-git@adamspiers.org>

On Wed, Sep 19, 2012 at 06:15:11PM +0100, Adam Spiers wrote:

>  test_failure_ () {
>  	test_failure=$(($test_failure + 1))
> -	say_color error "not ok - $test_count $1"
> +	say_color error "not ok $test_count - $1"

Interesting. I wondered what TAP had to say about this, and in fact we
were doing it wrong before. However, since the test numbers are optional
in TAP, a harness is supposed to keep its own counter when we fail to
provide a number.

So it happened to work, but this change in fact makes us more
TAP-compliant. Good.

-Peff