From: Jeff King Date: Sun, 09 Sep 2012 13:05:33 GMT Subject: Re: [PATCH v3 00/14] Clean up how fetch_pack() handles the heads list Message-ID: <20120909130532.GA27754@sigill.intra.peff.net> In-Reply-To: <7v7gs3sdjx.fsf@alter.siamese.dyndns.org> On Sun, Sep 09, 2012 at 03:20:18AM -0700, Junio C Hamano wrote: > Michael Haggerty writes: > > > This patch series depends on the "Add some string_list-related > > functions" series that I just submitted. > > Makes sense. The only worry (without reading the series first) I > have is that the use of string list may make the responsiblity of > sorting the list fuzzier. I am guessing that we never sorted the > refs we asked to fetch (so that FETCH_HEAD comes out in an expected > order), so use of unsorted string list would be perfectly fine. I haven't read the series yet, but both the list of heads from the user and the list of heads from the remote should have been sorted by 4435968 and 9e8e704f, respectively. -Peff