From: Jeff King <peff@peff.net>
Date: Thu, 23 Aug 2012 08:42:15 GMT
Subject: Re: [PATCH 05/17] Do not check the same match_pos twice
Message-ID: <20120823084213.GC6963@sigill.intra.peff.net>
In-Reply-To: <1345709442-16046-6-git-send-email-mhagger@alum.mit.edu>

On Thu, Aug 23, 2012 at 10:10:30AM +0200, mhagger@alum.mit.edu wrote:

> From: Michael Haggerty <mhagger@alum.mit.edu>
> 
> Once a match has been found at match_pos, the entry is zeroed and no
> future attempts will match that entry.  So increment match_pos to
> avoid checking against the zeroed-out entry during the next iteration.

Good catch.

A subtle side effect of this zero-ing (not introduced by your patch, but
something I noticed while re-reading the code) is that we implicitly
eliminate duplicate entries from the list of remote refs. There
shouldn't generally be any duplicates, of course, but I think skipping
them is probably sane.

-Peff