From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Thu, 16 Aug 2012 16:35:43 GMT
Subject: Re: [PATCH] help: correct behavior for is_executable on Windows
Message-ID: <20120816163543.GA45275@book.hvoigt.net>
In-Reply-To: <7vwr0z387c.fsf@alter.siamese.dyndns.org>

Hi Junio,

On Wed, Aug 15, 2012 at 07:02:31PM -0700, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > My preference is to remove "static int is_executable()" function
> > from help.c, have an...
> > ... I wouldn't mind seeing the implementation of posix_is_executable()
> > in help.c, which will be dead-code on Windows and Cygwin, if that
> > makes linking and Makefile easier.
> 
> An outline of such a change might look like this.

Thanks for the outline and the clarification, I will use it to cook up
something.

Cheers Heiko