From: Jeff King Date: Tue, 07 Aug 2012 21:59:46 GMT Subject: Re: [PATCH 2/2] prune.c: only print informational message in show_only or verbose mode Message-ID: <20120807215946.GB22974@sigill.intra.peff.net> In-Reply-To: <7vlihqv0ks.fsf@alter.siamese.dyndns.org> On Tue, Aug 07, 2012 at 02:44:51PM -0700, Junio C Hamano wrote: > Ok, so I'll queue it as a separate topic with a different > justification. > > -- >8 -- > From: Brandon Casey > Date: Mon, 6 Aug 2012 22:01:49 -0700 > Subject: [PATCH] prune.c: only print informational message in show_only or verbose mode > > "git prune" reports removal of loose object files that are no longer > necessary only under the "-v" option, but unconditionally reports > removal of temporary files that are no longer needed. > > The original thinking was that presence of a leftover temporary file s/presence/the &/ > should be an unusual occurrence that may indicate an earlier failure > of some sort, and the user may want to be reminded of it. Removing > an unnecessary loose object file, on the other hand, is just part of > the normal operation. That is why the former is always printed out > and the latter only when -v is used. > > But neither report is particularly useful. Hide both of these > behind the "-v" option for consistency. > > Signed-off-by: Brandon Casey > Signed-off-by: Junio C Hamano > --- Looks fine to me. I think tmpfile removal is also not that interesting in general. A stale file can happen any time the user aborts an operation via ^C. But I think your justification is sufficient as-is (and this topic is not worth spending too much more time on). -Peff