From: Jeff King <peff@peff.net>
Date: Tue, 07 Aug 2012 00:01:58 GMT
Subject: Re: [PATCH] Avoid crippled getpass function on Solaris
Message-ID: <20120807000158.GA17022@sigill.intra.peff.net>
In-Reply-To: <1344295889-sup-7899@pinkfloyd.chass.utoronto.ca>

On Mon, Aug 06, 2012 at 07:31:30PM -0400, Ben Walton wrote:

> Excerpts from Jeff King's message of Mon Aug 06 18:42:22 -0400 2012:
> 
> > +    if (strbuf_getwholeline(sb, fd, term))
> 
> Shouldn't this be strbuf_getwholeline_fd though?

Whoops, yes. When I got your email, I had just finished the patch but
had not yet written the follow-on patch that would actually exercise it.

-Peff