From: Jeff King Date: Mon, 06 Aug 2012 20:38:26 GMT Subject: Re: [PATCH 6/8] implement metadata cache subsystem Message-ID: <20120806203826.GA12073@sigill.intra.peff.net> In-Reply-To: <20120804171146.GF19378@sigill.intra.peff.net> On Sat, Aug 04, 2012 at 01:11:46PM -0400, Jeff King wrote: > +#define IMPLEMENT_CACHE(name, maptype, ktype, vtype) \ > +static struct map_persist_sha1pair_uint32 name##_map; \ A minor fixup, but this should obviously be "map_persist_##maptype". It doesn't matter for this series (since we only instantiate one cache, and it uses a sha1pair_uint32 map), but obviously this was meant to be generic... -Peff