From: Neil Horman <nhorman@tuxdriver.com>
Date: Mon, 06 Aug 2012 10:57:29 GMT
Subject: Re: [PATCH] cherry-pick: add --allow-empty-message option
Message-ID: <20120806105729.GC16873@hmsreliant.think-freely.org>
In-Reply-To: <86938f900c630d983852a250090f2aa6112fcc3c.1343903931.git.chris@arachsys.com>

On Thu, Aug 02, 2012 at 11:38:51AM +0100, Chris Webb wrote:
> Scripts such as git rebase -i cannot currently cherry-pick commits which
> have an empty commit message, as git cherry-pick calls git commit
> without the --allow-empty-message option.
> 
> Add an --allow-empty-message option to git cherry-pick which is passed
> through to git commit, so this behaviour can be overridden.
> 
> Signed-off-by: Chris Webb <chris@arachsys.com>
Sorry for the late response, but I just pulled back into town.

Having read over this thread, I think this is definately the way to go.  As
discussed having cherry-pick stop and give the user a chance to fix empty
history messages by default, and providing a switch to override that behavior
makes sense to me.  That said, shouldn't there be extra code here in the rebase
scripts to automate commit migration in that path as well?
Neil

>