From: Michał Kiedrowicz <michal.kiedrowicz@gmail.com>
Date: Fri, 03 Aug 2012 20:12:03 GMT
Subject: Re: [PATCH] tests: Introduce test_seq
Message-ID: <20120803221203.37e854d1@gmail.com>
In-Reply-To: <20120803200718.GA10648@sigill.intra.peff.net>

Jeff King <peff@peff.net> wrote:

> On Fri, Aug 03, 2012 at 10:04:50PM +0200, Michał Kiedrowicz wrote:
> 
> > Previous patch didn't support `test_seq 1 50` (I removed it accidentally).
> 
> Our emails just crossed paths. :)

Yeah :)

> 
> > +# test_seq is a portable replacement for seq(1).
> > +# It may be used like:
> > +#
> > +#	for i in `test_seq 100`; do
> > +#		echo $i
> > +#	done
> 
> This should probably note that it is a subset of seq's behavior. You
> talked about it in the commit message, but the in-code comment is a much
> more likely thing for a potential user to read.
> 
> -Peff

OK, I'll quote parameters and add a note.