From: Thomas Gummerer Date: Fri, 03 Aug 2012 12:46:32 GMT Subject: Re: [RFC 0/16] Introduce index file format version 5 Message-ID: <20120803124632.GD3226@tgummerer.unibz.it> In-Reply-To: On 08/03, Nguyen Thai Ngoc Duy wrote: > On Thu, Aug 2, 2012 at 6:01 PM, Thomas Gummerer wrote: > > Series of patches to introduce the index version 5 file format. This > > series does not include any fancy stuff like partial loading or partial > > writing yet, though it's possible to do that with the new format. > > I applied the series on top of master. I had to manually resolve > 09/16. You may want to rebase the series on master for the reroll > (less work for Junio) and remove trailing whitespaces in the patches. Thanks, I'll do that for the reroll. > All tests passed (with v5 by default (*), I notice it now), which is > wonderful. I'll have a closer look on the following days. Thank you > for working on this. > > (*) while it's good to run tests with v5 by default. I'm not sure if > we should make it by default in the next git release that comes with > v5. For one thing it'll stop older gits from using shared repos. And > we're not sure whether v5 introduces significant overhead in common > use cases. I didn't intent to make index v5 the format, I just oversaw the hunk that was changing it. I completely agree that v5 should not be default yet to avoid any surprises, also for users of jgit, libgit2 etc.