From: Eric Wong <normalperson@yhbt.net>
Date: Sat, 28 Jul 2012 02:59:12 GMT
Subject: Re: [PATCH 5/5] Change the rest of the code to use the Git::SVN and Git::SVN::Ra url accessors.
Message-ID: <20120728025912.GA28871@dcvr.yhbt.net>
In-Reply-To: <1343419252-9447-6-git-send-email-schwern@pobox.com>

"Michael G. Schwern" <schwern@pobox.com> wrote:

We try to keep Subject: lines short (~50 char soft limit) as documented
in SubmittingPatches.

How about:

Subject: [PATCH 4/5] use Git::SVN->path accessor globally
Subject: [PATCH 5/5] use Git::SVN{,::RA}->url accessor globally

?

I can make the changes to the commit message on my side before I push
for Junio.

> Note: The structure returned from Git::SVN->read_all_remotes() does
> not appear to contain objects, so I'm leaving them alone.

Right, just hashrefs and strings there.

> No functional change.

This series looks good with minor edits.

I made minor edits to reformat the new accessor subs (please do so on
your end before sending in the future).