From: Eric Wong Date: Fri, 27 Jul 2012 22:07:53 GMT Subject: Re: [PATCH 4/4] Move initialization of Git::SVN variables into Git::SVN. Message-ID: <20120727220753.GA7378@dcvr.yhbt.net> In-Reply-To: <7vsjcczxgu.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > Eric Wong writes: > > > I'll put the following after ms/makefile-pl but before ms/git-svn-pm: > > OK, it seems that you haven't pushed out the result yet (which is > fine); how do we want to proceed? Oops, got sidetracked into something else. Before I got sidetracked, my application of another patch in Michael's 3rd series failed (even with your updated Makefile patch): [PATCH 7/8] Extract Git::SVN::GlobSpec from git-svn GlobSpec.pm did not get picked up and placed into blib/ and some tests (t9118-git-svn-funky-branch-names.sh) failed as a result So I'll hold off until we can fix the build regressions (working on it now)