From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 23 Jul 2012 05:28:02 GMT
Subject: Re: [PATCH lt/block-sha1 0/2 v3] block-sha1: avoid pointer conversion that violates alignment constraints
Message-ID: <20120723052605.GA13728@burratino>
In-Reply-To: <7vobn7njtz.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:

>> The big-endian part was just my idiocy, sorry.
>
> Hrm, do we want an update log message for 1/2 then?

Hm, I thought all the crazy had been eliminated already.

*looks again*

I guess "using a single 32-bit load" makes it sound like it's using a
big-endian load instead of a load followed by twiddling in registers.

Simplest fix would be to drop the phrase "by using a single 32-bit
load", leaving "... and gcc takes full advantage, resulting in a whole
bunch of unaligned access traps."  Would that work for you, or should
I resend?

Thanks,
Jonathan