From: Jeff King Date: Wed, 18 Jul 2012 12:03:07 GMT Subject: [PATCH 0/4] mediawiki/credential cleanups Message-ID: <20120718120307.GA6399@sigill.intra.peff.net> Hi Matthieu, Your initial credential plumbing series went by while I was on vacation, and I finally got a chance to look at it in more detail. Overall it looks very good; thank you (and your students) for working on it. It was especially nice to have a test harness with complete instructions. :) I came up with a few commits on top. Patches 1 and 2 are cleanups that should hopefully be non-controversial. Patch 3 is the "url=" attribute we discussed earlier, and then patch 4 makes use of it in mw-to-git. [1/4]: docs/credential: minor clarity fixups [2/4]: mw-to-git: check blank credential attributes via length [3/4]: credential: convert "url" attribute into its parsed subparts [4/4]: mw-to-git: use git-credential's URL parser Documentation/git-credential.txt | 22 ++++++++++++++++------ contrib/mw-to-git/git-remote-mediawiki | 34 +++++----------------------------- credential.c | 2 ++ 3 files changed, 23 insertions(+), 35 deletions(-) -Peff