From: Jeff King <peff@peff.net>
Date: Thu, 28 Jun 2012 17:50:41 GMT
Subject: Re: [PATCH 2/3] Allow help.htmlpath to be an http: URL
Message-ID: <20120628175041.GA4731@sigill.intra.peff.net>
In-Reply-To: <20120628065623.GB1742@arachsys.com>

On Thu, Jun 28, 2012 at 07:56:23AM +0100, Chris Webb wrote:

> > This, and "://", both sound sensible.
> 
> I have no real preference between any of the suggestions so far: they'd all
> be completely fine with me. Peff's :// test for a URL is much better than my
> http: prefix, so should replace the latter if we need a test at all, but
> apart from that I don't mind at all.
> 
> Okay, I'll re-send now the :// version I did in response to Peff's first
> email purely on the basis that it doesn't change the behaviour at all for
> existing users who don't set htmlpath at all, plus it's already sat in my
> reflog!

I think the "://" one is my preference. I just looked over your v3
series, and the patches look good to me.

-Peff