From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 27 Jun 2012 21:22:31 GMT
Subject: Re: [PATCH v2 3/3] fast-import: disallow "merge $itself" command
Message-ID: <20120627212231.GM12774@burratino>
In-Reply-To: <1340818825-13754-4-git-send-email-divanorama@gmail.com>

Dmitry Ivankov wrote:

> "merge $itself" may be used to create commits with previous branch tip
> being repeated as n-th parent or even moved from being 1-st to be just
> n-th. This is not a documented use case and doesn't look like a common
> one.
[...]
> Just deny "merge $itself" for now. It was a bit broken and btw "from
> $itself" was and is a forbidden command too.

Lovely.  Thanks for a clear patch and clear explanation.

For what it's worth, this one is
Acked-by: Jonathan Nieder <jrnieder@gmail.com>

I'll think more about the other two and get back to you.