From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 20 Jun 2012 21:31:47 GMT
Subject: Re: [PATCHv3 11/11] Makefile: move GIT-VERSION-FILE dependencies closer to use
Message-ID: <20120620213147.GG6142@burratino>
In-Reply-To: <20120620183222.GK30995@sigill.intra.peff.net>

Jeff King wrote:

> There is a list of all of the targets which depend on
> GIT-VERSION-FILE, but it can be quite far from the actual
> point where the targets actually use $(GIT_VERSION). This
> can make it hard to verify that each use of $(GIT_VERSION)
> has a matching dependency.
>
> This patch moves the dependency closer to the actual build
> instructions, which makes verification easier.  This also
> fixes the generation of "configure", which did not properly
> mark the dependency.

Very nice.

Regards,
Jonathan