From: Ted Ts'o Date: Tue, 12 Jun 2012 19:43:56 GMT Subject: Re: Keeping unreachable objects in a separate pack instead of loose? Message-ID: <20120612194356.GD12161@thunk.org> In-Reply-To: On Tue, Jun 12, 2012 at 03:35:17PM -0400, Nicolas Pitre wrote: > > > > The race condition you've pointed out exists today, with the git prune > > racing against the git fetch. > > Yes, however that race is trivial to fix when loose objects are used. We can use the same trivial fix with the cruft pack, by touching the mtime of the pack. Yes, it will extend the lifetime of the cruft pack by another 2 weeks but again, let me remind you: 244k versus 4.5 megabytes. I can live with an extra 244k hanging around a wee bit longer. :-) There are other fixes we could do involving flock() and removing the cruft label once we add a reference to a cruft pack, that I don't think would be that complicated. - Ted